Review Request: [libplasmaclock] Selecting main time zone for clock.

[Rafa? Mi?ecki]

> On 2008-09-10 07:23:00, Anne-Marie Mahfouf wrote:
> > I applied the patch and I find the idea interesting. However what I would expect when I uncheck "Use local time zone" would be that the local time zone is highlighted in the list and appears in the combo box (instead of nothing, as there is automatically the local time zone set from System Settings). Is that posible?
> > 
> > I am writing tooltips and qwhatthis for this config dialog in order to explain to the user how it's done, will post it here when Zajec is done!
> 
> Aaron Seigo wrote:
>     > I would expect when I uncheck "Use local time zone" would be that the local time zone is highlighted in the list and appears in the combo box
>     
>     agreed; in fact, i wonder if we could just get rid of the "Use local time zone" checkbox altogether? we already just check d->timezone == localTimezone(), and the DataEngine provides us the local tz name:
>     
>     dataEngine("time")->query("Local")["Timezone"];
>     
>     other notes:
>     
>     * the combobox for selecting the main time zone should be left aligned to the label, not right aligned with the dilaog box
>     * 'Main time zone:' might be better as 'Default time zone:'

I updated patch and attached new screenshot. I didn't touch "Use local time zone" for now, wish to fix everything step by step. That will be probably next on my list.


- Rafa?


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/183/#review178
-----------------------------------------------------------


On 2008-09-10 06:02:29, Rafa? Mi?ecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/183/
> -----------------------------------------------------------
> 
> (Updated 2008-09-10 06:02:29)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Currently it is possible to select main time zone by mouse wheel only. By main time zone I mean the one used by clock, as other selected time zones are visible in tooltip only.
> This patch adds QComboBox to configuration dialog which also allows to select main time zone.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/timezonesConfig.ui
> 
> Diff: http://reviewboard.vidsolbach.de/r/183/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Dialog Clock Settings
>   http://reviewboard.vidsolbach.de/r/183/s/58/
> Settings after change
>   http://reviewboard.vidsolbach.de/r/183/s/59/
> 
> 
> Thanks,
> 
> Rafa?
> 
>