Review Request: [libplasmaclock] Selecting main time zone for clock.

[Anne-Marie Mahfouf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/183/#review178
-----------------------------------------------------------


I applied the patch and I find the idea interesting. However what I would expect when I uncheck "Use local time zone" would be that the local time zone is highlighted in the list and appears in the combo box (instead of nothing, as there is automatically the local time zone set from System Settings). Is that posible?

I am writing tooltips and qwhatthis for this config dialog in order to explain to the user how it's done, will post it here when Zajec is done!

- Anne-Marie


On 2008-09-10 06:02:29, Rafa? Mi?ecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/183/
> -----------------------------------------------------------
> 
> (Updated 2008-09-10 06:02:29)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Currently it is possible to select main time zone by mouse wheel only. By main time zone I mean the one used by clock, as other selected time zones are visible in tooltip only.
> This patch adds QComboBox to configuration dialog which also allows to select main time zone.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/timezonesConfig.ui
> 
> Diff: http://reviewboard.vidsolbach.de/r/183/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Dialog Clock Settings
>   http://reviewboard.vidsolbach.de/r/183/s/58/
> 
> 
> Thanks,
> 
> Rafa?
> 
>