Review Request: libplasmaclock: updating m_prettyTimezone inside lib instead of digital clock

[Rafa? Mi?ecki]

> On 2008-09-10 00:43:25, Sebastian Kügler wrote:
> > Looks good to me ...

Thanks, I shipped it.
People probably will need to recompile /trunk/KDE/kdeplasma-addons/applets/ after recompiling libplasmaclock. I mention this in case of some bug reports about fuzzyclock crashing plasma :)


- Rafa?


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/175/#review176
-----------------------------------------------------------


On 2008-09-09 13:26:22, Rafa? Mi?ecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/175/
> -----------------------------------------------------------
> 
> (Updated 2008-09-09 13:26:22)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch moves updating m_prettyTimezone into libplasmaclock as this m_prettyTimezone will be needed for every clock (we are going to use standarised tooltip soon).
> 
> Splitting code is also used in /trunk/KDE/kdebase/workspace/plasma/applets/timeengine.cpp
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/175/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rafa?
> 
>