Review Request: libplasmaclock: updating m_prettyTimezone inside lib instead of digital clock
Rafa? Mi?ecki
zajec5 at gmail.com
Tue Sep 9 22:24:08 CEST 2008
> On 2008-09-05 07:39:46, Marco Martin wrote:
> >
First version of patch was incorrect. Patching resulted in displaying texts like "Europe/Warsaw" instead of "Warsaw". Please, re-review current version.
- Rafa?
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/175/#review158
-----------------------------------------------------------
On 2008-09-09 13:24:02, Rafa? Mi?ecki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/175/
> -----------------------------------------------------------
>
> (Updated 2008-09-09 13:24:02)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This patch moves updating m_prettyTimezone into libplasmaclock as this m_prettyTimezone will be needed for every clock (we are going to use standarised tooltip soon).
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.h
> /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp
> /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.h
> /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.cpp
>
> Diff: http://reviewboard.vidsolbach.de/r/175/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rafa?
>
>
More information about the Plasma-devel
mailing list