Review Request: Let the plasmoid viewer have wallpaper and containment

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/180/#review174
-----------------------------------------------------------

Ship it!


few minor issues, but generally looks ok.


trunk/KDE/kdebase/workspace/plasma/shells/plasmoidviewer/fullview.cpp
<http://reviewboard.vidsolbach.de/r/180/#comment149>

    coding style; should be:
    
    if (!wallpaper.isEmpty()) {
        m_containment->setWallpaper(wallpaper);
    }



trunk/KDE/kdebase/workspace/plasma/shells/plasmoidviewer/fullview.cpp
<http://reviewboard.vidsolbach.de/r/180/#comment150>

    the containment should resize the wallpaper all on its own, really. if this line is necessary, then the containment isn't being positioned properly.



trunk/KDE/kdebase/workspace/plasma/shells/plasmoidviewer/main.cpp
<http://reviewboard.vidsolbach.de/r/180/#comment151>

    the else isn't needed; usageError result in program termination.


- Aaron


On 2008-09-08 15:28:17, Aleix Pol wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/180/
> -----------------------------------------------------------
> 
> (Updated 2008-09-08 15:28:17)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/shells/plasmoidviewer/fullview.h
>   trunk/KDE/kdebase/workspace/plasma/shells/plasmoidviewer/fullview.cpp
>   trunk/KDE/kdebase/workspace/plasma/shells/plasmoidviewer/main.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/180/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix
> 
>