Review Request: theme panel controller with plasma widgets

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/177/#review168
-----------------------------------------------------------

Ship it!


cool; one question: why is the text in the Visibility option buttons centered? =)

- Aaron


On 2008-09-07 08:18:54, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/177/
> -----------------------------------------------------------
> 
> (Updated 2008-09-07 08:18:54)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> uses plasma theme svgs to paint the elements in the panel controller
> looks nicer and as a bonus the code it's a bit simpler
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/positioningruler.cpp
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/toolbutton.h
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/toolbutton.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/177/diff
> 
> 
> Testing
> -------
> 
> tested at different screen edges
> 
> 
> Screenshots
> -----------
> 
> new look
>   http://reviewboard.vidsolbach.de/r/177/s/57/
> 
> 
> Thanks,
> 
> Marco
> 
>