Review Request: Plasma::Dialog resize feature

[Alessandro Diaferia]

> On 2008-09-07 03:47:53, Loic Marteau wrote:
> > trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp, lines 168-184
> > <http://reviewboard.vidsolbach.de/r/172/diff/2/?file=866#file866line168>
> >
> >     Perhaps a stupid question isn't MousePressEvent/(MouseReleaseEvent for the unset) a better place for this ?

Well, no :P When you move your mouse around the corner the cursor should change automatically.. As happens for your normal windows you just have to put the mouse on the edges for it to change its shape (without pressing/releasing) :)


- Alessandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/172/#review163
-----------------------------------------------------------


On 2008-09-07 03:06:50, Alessandro Diaferia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/172/
> -----------------------------------------------------------
> 
> (Updated 2008-09-07 03:06:50)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> With this patch you can programmatically choose a corner to let users resize Plasma::Dialog. Together with notmart we were thinking about automagically change the corner chosen in case it is too near to screen edges.. Btw, since the resize is an important feature IMO i'm asking now for the review of this patch. No meaningful screenshots come with this patch since you could only see a resize cursor on one of the four corners =)
> If this patch is ok to commit i can quickly patch kickoff to allow resize (simply setResizeHandleCorner(Dialog::NorthEast));
> 
> UPDATE:
> The patch has been updated according to Aaron's suggestions. No more useless widgets, just changing of cursors on edges, possibility of using "OR'ed" flags and cleaner code (IMO).
> 
> Please Review this new patch =)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasma/dialog.h
>   trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/172/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alessandro
> 
>