Patch: New KRunner searches context of Dolphin Places Panel

[Aaron J. Seigo]

On Friday 05 September 2008, David Edmundson wrote:
> Aaron Seigo wrote:
> > m_filePlaces = new KFilePlacesModel() gets leaked;
>
> Didn't know that, I think I have some other code to check now!

=)

> > it would be good to show an error, perhaps via KMessageBox, when setup
> > fails in setupComplete; silent failures suck for the user.
>
> I managed to get it to fail (by breaking my fstab), and as guessed my code
> does nothing. I then tried doing the same thing in Device Manager, and that
> just opens Dolphin in the wrong place. Would it make more sense for the
> error message to go in the code KFilePlacesModel calls in requestSetup?
> That way we only need one error message not one per app using it.

that would require auditing every app that uses KFilePlacesModel to make sure 
it makes sense to show such an error ...

> > has become (file dialog, dolphin, kickoff, gwenview, etc)
>
> I've added it to kdeplasma-addons. Then it can be moved if people think
> otherwise.

yes, i'd like to see this in kdebase.

> > - what's kdDebug? (I've never heard of this, maybe something useful to
> > know?)
>
> kdDebug() is a way of printout to the screen during execution, if you debug

kdDebug() is was kDebug() used to be calle; it's a depricated synonym for  
kDebug() these days =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080905/5883f0a6/attachment.sig