Review Request: a signal for the activity change

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/176/#review162
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/libs/plasma/containment.h
<http://reviewboard.vidsolbach.de/r/176/#comment131>

    how about just contextChanged?



/trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
<http://reviewboard.vidsolbach.de/r/176/#comment130>

    actually, in ContainmentPrivate::context() where it creates the Context object, just connect the Context::changed signal to the Containment::contextChanged signal.
    
    there's more to Context than just the activity (geographical location will be one, for instance)


- Aaron


On 2008-09-05 11:19:45, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/176/
> -----------------------------------------------------------
> 
> (Updated 2008-09-05 11:19:45)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is the first time i try to scratch my itch with activity and context stuff, so probably could be not the right approach(tm)
> this adds a signal to the containment that notifies the activity has changed, since i think could be useful tools that displays activities
> i made this thing for activitybar in playground, that displays all the containments in a tabbar for quick switching, so i need a way to sync the name with the text on tabs.
> a way could be this signal, or perhaps directly accessing the context object fron the containment?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/176/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>