Review Request: Moving m_time, m_date and m_prettyTimeZone variables into libplasmaclock

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/173/#review157
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.h
<http://reviewboard.vidsolbach.de/r/173/#comment128>

    why do you need the time and date members?
    
    moving m_prettyTimezone makes sense as all timezone handling moves into the lib, however does it need to be public?


- Aaron


On 2008-09-05 01:35:02, Rafa? Mi?ecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/173/
> -----------------------------------------------------------
> 
> (Updated 2008-09-05 01:35:02)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> To move standarised tooltip from digital clock into libplasmaclock I need to have access to theses variables inside libplasmaclock.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.h
>   /trunk/KDE/kdeplasma-addons/applets/binary-clock/binaryclock.h
>   /trunk/KDE/kdeplasma-addons/applets/binary-clock/binaryclock.cpp
>   /trunk/KDE/kdeplasma-addons/applets/fuzzy-clock/fuzzyClock.h
> 
> Diff: http://reviewboard.vidsolbach.de/r/173/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rafa?
> 
>