Review Request: Digital clock: Fix saving selected timezone

Aaron Seigo aseigo at kde.org
Fri Sep 5 16:36:59 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/174/#review156
-----------------------------------------------------------

Ship it!


- Aaron


On 2008-09-05 01:44:59, Rafa? Mi?ecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/174/
> -----------------------------------------------------------
> 
> (Updated 2008-09-05 01:44:59)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I discovered bug that after changing timezone (it's possbile using mousewheel over clock) and restarting applet/KDE, the choice is not remembered.
> That's because digital clock doesn't have idea about changing timezone (mousewheel) and it overwrites timezone set by ClockApplet. As ClockApplet remembers choice, it is not longer needed to do it inside digital clock.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/174/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rafa?
> 
>



More information about the Plasma-devel mailing list