Review Request: Plasma::Dialog resize feature

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/172/#review150
-----------------------------------------------------------



trunk/KDE/kdebase/workspace/libs/plasma/dialog.h
<http://reviewboard.vidsolbach.de/r/172/#comment123>

    should this be a set of flags instead so one can do: setResizeCorners(NorthEast|SouthEast) or setResizeCorners(All)?



trunk/KDE/kdebase/workspace/libs/plasma/dialog.h
<http://reviewboard.vidsolbach.de/r/172/#comment124>

    i wonder if we actually need a resize handle at all? could the dialog not just change the cursor and have it activated on the edges of the window itself? that would mean no extra painting, no extra QWidgets in memory ...?



trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
<http://reviewboard.vidsolbach.de/r/172/#comment122>

    you don't need a boolean for showResizeHandle when you can just check if (resizeHandle)


- Aaron


On 2008-09-04 08:37:06, Alessandro Diaferia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/172/
> -----------------------------------------------------------
> 
> (Updated 2008-09-04 08:37:06)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> With this patch you can programmatically choose a corner to let users resize Plasma::Dialog. Together with notmart we were thinking about automagically change the corner chosen in case it is too near to screen edges.. Btw, since the resize is an important feature IMO i'm asking now for the review of this patch. No meaningful screenshots come with this patch since you could only see a resize cursor on one of the four corners =)
> If this patch is ok to commit i can quickly patch kickoff to allow resize (simply setResizeHandleCorner(Dialog::NorthEast));
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasma/dialog.h
>   trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/172/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alessandro
> 
>