Fwd: Re: Patch for Bug 168126 (set different icons size for each folderview)

Benjamin Kleiner bizzl.greekdog at web.de
Thu Sep 4 20:31:37 CEST 2008


Hmmm... it's probably a bad idea to not send to the mailing list.
Sorry for the long delay, hope the diffs are still useful...

> i probably wasn't clear enough in my explanation, sorry =/ what i meant by
> "add a page to the dialog for each group" was to call parent->addPage for
> each set of configurations (see the parrent->addPage(widget,
> parent->windowTitle(), icon()); call currently there for an example). this
> will result in the proper display automagically following how the rest of
> plasma does it.
Oh, dumb me, sry.
I hacked this in within minutes, it works for me, but I can't really diff against the current svn without bloating the diff files, 'cause that wouldn't work anymore (can't set up a 
whole trunk build atm, my notebook would burn :( ), I hope that's okay.

> otherwise, i like it, though now we don't have to hide the filtering
> widgets as they don't take up a lot of space; instead they should just be
> enabled/disabled instead of shown/hidden.
Sure, no problem, is done in the attached patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20080904/61c70b47/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: folderview.patch.zip
Type: application/zip
Size: 7812 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080904/61c70b47/attachment-0001.zip 


More information about the Plasma-devel mailing list