Review Request: Clock: cleaning tool tip code

Rafa? Mi?ecki zajec5 at gmail.com
Wed Sep 3 18:58:33 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/169/
-----------------------------------------------------------

(Updated 2008-09-03 09:58:33.495805)


Review request for Plasma.


Summary
-------

This patch makes little cleaning in tool tip code and prepare for next changes. For now new function
QPair<> toolTipContent()
was created. The next step will be to move updateToolTipContent() into libplasmaclock.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.h
  /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp
  /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.h
  /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.cpp

Diff: http://reviewboard.vidsolbach.de/r/169/diff


Testing
-------

Tool tip for digital clock still works, analog clock doesn't crash (it doesn't have tool tip).


Thanks,

Rafa?



More information about the Plasma-devel mailing list