plasma/kdelibs coding style and pointers

Aaron J. Seigo aseigo at kde.org
Mon Sep 1 18:04:19 CEST 2008


On Sunday 31 August 2008, Jason Stubbs wrote:
> The kdelibs coding style on techbase[1] only says "For pointers or
> references, use a single space before '*' or '&', but not after". When
> looking through applet.h and applet.cpp, I see this rule being broken in
> some circumstances. Am I right to believe that the first in each of the
> following groups is "correct"?

below are ones that are "correct"

> QString *p;

> void foo(QString *p);

> Blah * const d;

> QString* Blah::foo();

ones that i don't really care about:

> QList<Blah*> foo;
> QList<Blah *> foo;

and these are "wrong" because they should always have a variable name:

> void foo(QString*);
> void foo(QString *);

if you see code that isn't correct in svn, correct as you work around/near 
them and try and catch it before or directly after it goes into svn ..

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080901/c0714fa0/attachment.sig 


More information about the Plasma-devel mailing list