Review Request: removal of windowChangedGeomtetry signal

Christian Mollekopf chrigi_1 at hotmail.com
Thu Oct 30 01:20:18 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/246/
-----------------------------------------------------------

Review request for Plasma, Aaron Seigo and Marco Martin.


Summary
-------

Remove the windowChangedGeomtetry signal from the TaskManager and use the new itemChanged(item*, changes) signal.
make it possible to turn of geometryTracking after it was turned on once.


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h
  /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp
  /trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h
  /trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.cpp

Diff: http://reviewboard.vidsolbach.de/r/246/diff


Testing
-------

tried out if the tracking is enabled when showOnlyCurrentScreen is enabled.
haven't tried the actual mutlti screen stuff but i didn't change this code so it should still work =)


Thanks,

Christian



More information about the Plasma-devel mailing list