Review Request: Make sure that focused result item is visible when navigating with Tab key

Aaron Seigo aseigo at kde.org
Wed Oct 29 05:42:05 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/245/#review237
-----------------------------------------------------------

Ship it!


- Aaron


On 2008-10-26 16:13:07, Dmitry Suzdalev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/245/
> -----------------------------------------------------------
> 
> (Updated 2008-10-26 16:13:07)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> This patch makes krunner's ResultScene correctly update current page when navigating through items using Tab key.
> Without this patch it works correctly (i.e. page is changed as user focuses some item on a next page) only if Up/Down/Left/Right keys are pressed.
> As we can't catch Key_Tab in keyPressEvent, we'll watch for item selection events.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/krunner/resultscene.h
>   /trunk/KDE/kdebase/workspace/krunner/resultscene.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/245/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>



More information about the Plasma-devel mailing list