Review Request: Make sure that focused result item is visible when navigating with Tab key

Dmitry Suzdalev dimsuz at gmail.com
Mon Oct 27 00:11:43 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/245/
-----------------------------------------------------------

(Updated 2008-10-26 16:11:43.080868)


Review request for Plasma and Aaron Seigo.


Summary
-------

This patch makes krunner's ResultScene correctly update current page when navigating through items using Tab key.
Currently it works correctly (i.e. page is changed as user focuses some item on a next page) only if Up/Down/Left/Right keys are pressed.
As we can't catch Key_Tab in keyPressEvent, we'll watch for item selection events.


Diffs
-----

  /trunk/KDE/kdebase/workspace/krunner/resultscene.h
  /trunk/KDE/kdebase/workspace/krunner/resultscene.cpp

Diff: http://reviewboard.vidsolbach.de/r/245/diff


Testing
-------


Thanks,

Dmitry



More information about the Plasma-devel mailing list