tasks painting semplification

Jamboarder jamboarder at yahoo.com
Mon Oct 27 17:08:33 CET 2008


> From: Marco Martin <notmart at gmail.com>
> aaanyways, the painting function it's really a mess because when i added the 
> support for svg theming i decided to add a fallback for every element, so when 
> it does not exist in the svg just paints a rounded rectangle, so the code is 
> 80% manual qpainter cruft.
> now, would be interesting as a general rule how to behave in this cases, i 
> think that just removing the fallbackswould make way more cleaner code.
> i kinda remember chatting with aaron on a similar situation (don't remember 
> what was the theme/plasmoid in particular) was decided to just consider it a 
> problem of who makes the theme to ensure all the elements are in
> what do you guys think?
As long as the default theme tasks.svg has the required elements, it should behave much the same as other theme elements: When the theme author omits the svg, use the default theme svg.  I'm all for doing away with the qpainter cruft.

Hope this helps,
Andrew (Jamboarder) Lake


More information about the Plasma-devel mailing list