plasma apps and screen information

[Guillaume Pothier]

On Fri, Oct 24, 2008 at 12:08 PM, Guillaume Pothier <gpothier at gmail.com> wrote:
> Ok, here comes the patch. In summary:
> - Added three methods to Corona:
>   int numScreens()
>   QRect screenGeometry(int)
>   QRect availableScreenGeometry(int)
> The latter should probably return a QRegion instead, according to what
> you said about toolbox placement.
> - QDesktopWidget is not used anymore in libplasma, entirely replaced
> by calls to the new Corona methods.
> - Added Corona* parameter to Plasma::popupPosition
> - Added a corona() method to Plasma::Applet. This is needed for calls
> to Plasma::popupPosition.
> - Also added a corona() method to Plasma::View for consistency's sake.
> - Corona is friends with ToolTipManager, as ToolTipManager needs to
> call Plasma::popupPosition and thus needs a Corona. Thus, Corona
> registers itself with the ToolTipManager. I think this is the ugliest
> part of the patch, please tell me if there is a better solution.
> - Added a ViewerCorona class to plasmoidviewer, as Plasma::Corona is
> now has pure virtual methods.
>
> Ok to commit?

Any comment about the patch?
Another thing: I noticed Lancelot instantiates a Plasma::Corona
(LancelotWindow.cpp:205). That doesn't work anymore with my patch, as
Corona has pure virtual methods. Why is Lancelot instantiating its own
corona?
Cheers,
g