Review Request: LayoutWidget overhaul and some other stuff

[Marco Martin]

On Saturday 25 October 2008, Christian Mollekopf wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/241/
> -----------------------------------------------------------
>
> Review request for Plasma and Aaron Seigo.
>
>
> Summary
> -------
>
> Hopefully the last major overhaul of the LayoutWidget, i put the
> calculation of the coumns and the rows together since they are logically
> tied and removed a lot of unused or unecessary stuff. Renamed all fillRows
> stuff to forceRows. Further i implemented some vertical layout stuff so it
> should be basically working now. Also the automatic calculation of the
> columns is now implemented though not yet perferct.
>

err, review board seems broken :/

Cheers,
Marco Martin

> Diffs
> -----
>
>   trunk/KDE/kdebase/workspace/plasma/applet/tasks/layoutwidget.h
>   trunk/KDE/kdebase/workspace/plasma/applet/tasks/layoutwidget.cpp
>   trunk/KDE/kdebase/workspace/plasma/applet/tasks/taskgroupitem.h
>   trunk/KDE/kdebase/workspace/plasma/applet/tasks/taskgroupitem.cpp
>   trunk/KDE/kdebase/workspace/plasma/applet/tasks/tasks.cpp
>
> Diff: http://reviewboard.vidsolbach.de/r/241/diff
>
>
> Testing
> -------
>
> just basic testing. i tried it shortly.
>
>
> Thanks,
>
> Christian
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel