Review Request: new meter theming approach
Marco Martin
notmart at gmail.com
Thu Oct 23 23:24:23 CEST 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/239/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
the old theming for Plasma::Meter deformed the bar way too much when it was resized too wide
this uses panelsvg and tiling to do the image, and there is the new theme..
it should be retrocompatible with old themes, still falls back at the old elements
it does have a problem, when the number of tiles is not integer it rounds to the lower integer and mover the progressbar pattern at the centr, so there are little margins at both sides.
maybe not reeally pretty but still better than the deformed old one i think
Diffs
-----
/trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp
/trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_horizontal.svgz
/trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_vertical.svgz
Diff: http://reviewboard.vidsolbach.de/r/239/diff
Testing
-------
Screenshots
-----------
http://reviewboard.vidsolbach.de/r/239/s/84/
Thanks,
Marco
More information about the Plasma-devel
mailing list