Review Request: Drag from panel and drop to desktop PATCH

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/237/#review231
-----------------------------------------------------------


this is a must have feature; you're most of the way there it seems, too. =)



trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelappletoverlay.cpp
<http://reviewboard.vidsolbach.de/r/237/#comment182>

    why is this change needed? it actually looks wrong for non-layout-using panels (not that we have any atm, but still =)



trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelappletoverlay.cpp
<http://reviewboard.vidsolbach.de/r/237/#comment183>

    i think this is a bit aggressive; we should allow the mouse to "wander" at least a bit so you don't have to be extra careful in keeping your mouse inside the panel ... so maybe sth like qMin(parent()->height() *2, 200) or some such?
    
    also, this shouldn't really be on mouse release, but when it goes out of the "boundary zone" then the applet should detach, as we do in AppletHandle, and start "floating" about.
    
    in a perfect world, if you move out too far then back it would "re-attach" into the panel in question ...


- Aaron


On 2008-10-22 12:26:07, Alessandro Diaferia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/237/
> -----------------------------------------------------------
> 
> (Updated 2008-10-22 12:26:07)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> This patch allows moving an applet from panel to desktop. Its state is really basic but i felt this feature missing. I talked about this patch together with notmart and we'd like to know the best way to draw the applet even out of the panel while dragging. Please test this little patch and let me know =)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelappletoverlay.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/237/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alessandro
> 
>