Problems with the new tasks applet

[Petri Damstén]

On Wednesday 22 October 2008 20:42:25 Petri Damstén wrote:
> [ ] Show tooltips (One more thing. Tooltips popup even if this is
> unchecked)

And for that:

Index: abstracttaskitem.cpp
===================================================================
--- abstracttaskitem.cpp        (revision 874912)
+++ abstracttaskitem.cpp        (working copy)
@@ -66,7 +66,6 @@
       m_showTooltip(showTooltip),
       m_showingTooltip(false)
 {
-    m_showTooltip = showTooltip;
     setSizePolicy(QSizePolicy(QSizePolicy::Expanding,QSizePolicy::Expanding));
     setAcceptsHoverEvents(true);
     setAcceptDrops(true);
@@ -87,7 +86,7 @@
 void AbstractTaskItem::setShowTooltip(const bool showit)
 {
     m_showTooltip = showit;
-    updateToolTip();
+    // updateToolTip(); // Is this needed. It's called in toolTipAboutToShow
 }

 void AbstractTaskItem::setText(const QString &text)
@@ -136,9 +135,13 @@

 void AbstractTaskItem::toolTipAboutToShow()
 {
+    if (m_showTooltip) {
     m_showingTooltip = true;
     updateToolTip();
+    } else {
+        Plasma::ToolTipManager::self()->setContent(this);
 }
+}

 void AbstractTaskItem::toolTipHidden()
 {

ok to commit?

Petri