Review Request: Device Notifier restyle: part 1

Alessandro Diaferia alediaferia at gmail.com
Mon Oct 20 19:46:27 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/226/
-----------------------------------------------------------

(Updated 2008-10-20 10:46:27.526791)


Review request for Plasma and Aaron Seigo.


Summary
-------

This is the first part of Device Notifier restyle. Just ported to PopupApplet + a bonus: good use of tooltips as you can see in the screenshots.

UPDATE: diff updated according to Aaron's suggestions


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h
  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp

Diff: http://reviewboard.vidsolbach.de/r/226/diff


Testing
-------

Just works as expected


Screenshots
-----------

no device
  http://reviewboard.vidsolbach.de/r/226/s/81/
device plugged
  http://reviewboard.vidsolbach.de/r/226/s/82/


Thanks,

Alessandro



More information about the Plasma-devel mailing list