Review Request: big visual drop target when dropping applets on panel

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/227/#review224
-----------------------------------------------------------


should this be in plasma/shells/desktop/panelview.cpp? because then we can share the AppletMoveSpacer (for consistent visualization) and this will work with any panel that uses a linear layout, and not only the PanelContainment?

another concern i have is that the drag enter doesn't look at what is being dragged in. it should probably be limited to things we can accept (URLs, applets ..)

as for the dragLeave event issue ... one hack that *might* work is to do a QCoreApplication::postEvent; when a drag starts it creates an inner event loop and i'll bet that QCoreApplet::postEvent uses the application global event, meaning that when the drag even loop goes away we'll get the posted event and can do a check for the spacer then. a bit tricksy, but it might work =)

- Aaron


On 2008-10-19 11:51:42, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/227/
> -----------------------------------------------------------
> 
> (Updated 2008-10-19 11:51:42)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> when dropping an applet from the applet browser a big empty area appears in between the two applets most near the mouse cursor, making it easier to hit an empty area of the panel with drag and drop.
> 
> seems to work quite good, only problem that don't really know how to address is that pressing esc with the cursor in the panel doesn't dragleave won't get called, so the empty space stays here
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.h
>   /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/227/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>