Review Request: PopupApplet: bad aspect ratio behavior
Alessandro Diaferia
alediaferia at gmail.com
Fri Oct 17 09:26:38 CEST 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/223/
-----------------------------------------------------------
Review request for Plasma and Aaron Seigo.
Summary
-------
Hey Aaron, i had a good night since i think i understood correctly what you meant. Is the patch ok now? :) (For those who don't know, the patch avoids a bad behavior of popupapplet: it ignored the aspectratio set in the ctor after calling setPopupIcon.).
Diffs
-----
trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
Diff: http://reviewboard.vidsolbach.de/r/223/diff
Testing
-------
Works pretty well.. Of course i'll remove the white space on line 79 if ok to commit... :)
Thanks,
Alessandro
More information about the Plasma-devel
mailing list