Review Request: Pretty panel fail

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/221/#review220
-----------------------------------------------------------

Ship it!


- Aaron


On 2008-10-08 01:01:42, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/221/
> -----------------------------------------------------------
> 
> (Updated 2008-10-08 01:01:42)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The failedtolaunch message is too big for the panel, actually destroying the layout (having an enormous minimum size)
> this patch adds an icon with tooltip that is the only thing shown in the panel.
> it's half done in flushpendingconstraintsevent because in setfailedtolaunch there is still no formfactor or containment
> it's still a bit gross, it only manages change from planar to panel formfactors and the tooltip is always shown.
> a solution could be moving the construction of failurelayout in flushpendingconstaintsevent, but for that i would need the string of the failure reason saved in appletprivate, not sure of that, hmm..
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/applet.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/221/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.vidsolbach.de/r/221/s/80/
> 
> 
> Thanks,
> 
> Marco
> 
>