Review Request: Fixes crash on programgrouping with startup tasks

Marco Martin notmart at gmail.com
Tue Oct 7 17:00:18 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/219/#review218
-----------------------------------------------------------

Ship it!


sounds good, grouping starting tasks probably wouldn't make sense anyways

- Marco


On 2008-10-07 03:25:17, Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/219/
> -----------------------------------------------------------
> 
> (Updated 2008-10-07 03:25:17)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> This should fix the crash in programgroupingstrategy as described by Sebastian Kügler.
> The problem was that the strategy had access to startup tasks via the rootGroup.
> I shortly checked all other strategies but this shouldn't be a problem there.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/219/diff
> 
> 
> Testing
> -------
> 
> i just tried it shortly, should work.
> 
> 
> Thanks,
> 
> Christian
> 
>



More information about the Plasma-devel mailing list