Review Request: Desktop Settings Theme Details

[Andrew Lake]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/212/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Adds a "Theme Details" tab to the Desktop Settings.  Allows user to change individual theme items by picking from another theme or from a file specified by the user.  Just scratching an itch... been envying analog clocks from some themes and thought it would be useful to be able to do this easily.

(Just realized that this might have been a pretty big patch for review board, but oh well... let me know if you prefer to do this differently)

Hope this helps and please feel free to provide feedback.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/BackgroundDialog.ui
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.h
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.cpp

Diff: http://reviewboard.vidsolbach.de/r/212/diff


Testing
-------

Tested over the past week with a variety of use cases.  

The functionality is essentially complete and ready for use/testing. Didn't want to hold on to this much longer since it would be better if this could get tested by more than me.

TODO:
- Remove theme button does nothing right now but shouldn't take very long to get that in.
- Export theme button does nothing yet.
- Specifying a new theme name works but doesn't yet ask for confirmation of overwrite if specified name matches existing theme.


Screenshots
-----------

New Tab
  http://reviewboard.vidsolbach.de/r/212/s/72/
Theme Details Tab
  http://reviewboard.vidsolbach.de/r/212/s/73/
from file...
  http://reviewboard.vidsolbach.de/r/212/s/75/
Mix and Match and More
  http://reviewboard.vidsolbach.de/r/212/s/76/


Thanks,

Andrew