Review Request: style tabbar scroll buttons

Aaron Seigo aseigo at kde.org
Sun Oct 5 19:51:50 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/209/#review215
-----------------------------------------------------------

Ship it!


- Aaron


On 2008-10-04 10:49:52, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/209/
> -----------------------------------------------------------
> 
> (Updated 2008-10-04 10:49:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> tabbar scroll buttons were massively fugly, with a gray background, this patch (a bit convoluted, didn't find easier ways to disable the rendering of children:)) draws them with plasma colors.
> still no svg don't think it's worth adding new elements just for that
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/private/nativetabbar.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/tabbar.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/209/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.vidsolbach.de/r/209/s/71/
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Plasma-devel mailing list