Review Request: toolbox actions as toolbar when zoomed out

Marco Martin notmart at gmail.com
Thu Nov 27 23:34:54 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/285/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

this makes the toolbox actions to be drawn in an horizontal line and the cashew isn't drawn, it feels reeally dirty the polling for view transform in the paint event, but really don't know how to react differently (a zoomed view signal could be useful maybe?, or maybe this approach is the least damage compared to adding signals now:)

there are still know problems/things, like:
maybe should be drawn outside the containment, but for that need to change the containment positioning, so would rather get an initial working thing in before :)

on the second level of zoom the toolbox becomes bigger than the containments, so only icons should be shown, iconwidget lacks such an option, so either adding it now or using toolbuttons

anything else? (yes, pretty sure it is:p)


Diffs
-----

  /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp
  /trunk/KDE/kdelibs/plasma/private/toolbox.cpp
  /trunk/KDE/kdelibs/plasma/private/toolbox_p.h

Diff: http://reviewboard.vidsolbach.de/r/285/diff


Testing
-------


Thanks,

Marco



More information about the Plasma-devel mailing list