[PATCH] Show the job progress in separate dialog

[Aaron J. Seigo]

On Thursday 27 November 2008, Andras Mantia wrote:
> Hi,
>
>  the attached patch introduces a config option to show the job progress
> dialogs as separate dialogs. The reason is:
> 1) people are used to the old ones
> 2) the new ones, integrated into the systray notification have  some
> limitation compared to the old ones, like not being visible every time,
> so you don't know if a job stuck, finished, whatever;

not being constantly visible is a bit of a feature, really. but you can just 
click on the computer icon to see them. (or drag them out of the extender to 
some other place).

what would be good, however, is when they stop/die that it pops up 
automatically so you can see that.

> the information
> given is not that detailed;

all the information is in the dataengine so it's possible to show it in the 
status widgets.

> they disappear after the timeout, etc.

click on the icon =)

> I know 2) can be improved over time, but the timeframe to 4.2 is short
> and as no new strings can be introduced, I doubt it is possible now.

it's completely possible; just need someone to do it.

> There is no GUI configuration, again because of the string freeze. The
> option is global, I don't even know if it would be possible to have both
> the separate and the integrated dialogs.

not really.

> The patch doesn't react to config file changes, if requested, I can do
> that part.

no, that's fine.

> There is a question what should be the default. As it is now, I'd think
> showing the separate dialogs should be the default because of 2) and
> because some bugs. 

if a feature is buggy the solution isn't to hide it away where nobody can see 
it so that nobody feels the need to fix it. the solution is to *fix the 
feature*. we have, what, 6 weeks to do that in? note that the integration of 
jobs was started, i think, 3 days before the freeze. ;) so it's not like it's 
been sitting there this way for months ...

> Anyway the patch tries to be not intrusive, so I made
> to have the current behavior the default, so people can test in beta
> stage and report bugs. :)

the patch looks ok, though Manager::Private::registerJobProtocol() could just 
be rolled right into Manager::Private.

the same should also be done for the notifications, btw.

in 4.3 we can add to the config dialog for these options, but the default 
should remain as they are since the point of plasma is an integrated 
experience. it's pretty obvious not everyone will want that, so we need these 
options (i'm impressed it only took, what, 2 weeks or so for the first patch to 
show up? =) ... 

feel free to commit.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20081127/2c1dfb74/attachment.sig