Re: Review Request: make Calendar a popupÂpplet

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/276/#review269
-----------------------------------------------------------

Ship it!


looks good

- Marco


On 2008-11-21 15:19:34, Loic Marteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/276/
> -----------------------------------------------------------
> 
> (Updated 2008-11-21 15:19:34)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hey Marco
> 
> Here is the code to make the calendar a popupApplet.
> 
> Im not able to work on changing the icon with the date of the day, do you think that this is really important ? Perhaps in panel mode calendar make less sense as clocks does in fact the same job ?!
> 
> Cheers
> 
> Lo
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/calendar/calendar.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/calendar/calendar.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/276/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Loic
> 
>