Review Request: Bug with Plasma::Delegate text painter

[Jesse Zamora]

> On 2008-11-20 13:38:23, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/plasma/delegate.cpp, lines 300-328
> > <http://reviewboard.vidsolbach.de/r/274/diff/3/?file=1527#file1527line300>
> >
> >     there's no point in painting this if the text fits, right? that would avoid painting this for every single item.

Yup. That's why I added the code that checks if the titleRect or the subTitleRect is too large; if it's too large, it draws the gradient.


- Jesse


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/274/#review266
-----------------------------------------------------------


On 2008-11-20 13:06:28, Jesse Zamora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/274/
> -----------------------------------------------------------
> 
> (Updated 2008-11-20 13:06:28)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I have fixed the bug in Plasma::Delegate (in the screenshot) where long strings run out of the item rects and make it look ugly. It adds a gradient to make it look better (as in the 2nd screenshot). Please test & review this patch so maybe it can go into trunk for KDE 4.2.
> 
> Xtreme Kommander
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/delegate.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/274/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Plasma delegate text painting bug
>   http://reviewboard.vidsolbach.de/r/274/s/94/
> Fixed bug in Plasma::Delegate
>   http://reviewboard.vidsolbach.de/r/274/s/95/
> 
> 
> Thanks,
> 
> Jesse
> 
>