Review Request: Bug with Plasma::Delegate text painter

[Marco Martin]

On Wednesday 19 November 2008, Jesse Zamora wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/274/
> -----------------------------------------------------------
>
> (Updated 2008-11-19 13:49:28.145433)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> I have fixed the bug in Plasma::Delegate (in the screenshot) where long
> strings run out of the item rects and make it look ugly. Please review this
> patch and tell me if there's anything I can do to make it better.
>
> Xtreme Kommander
>
> P.S. Does anyone know how I may check the text orientation? If a language
> has right-to-left text orientation, then this patch wouldn't work too
> well....
in the delegate option->direction
otherwise QApplication::layoutDirection() as aaron said
and you can do a quick text lauching plasma with the --reverse option, would 
look a bit weird since the text will still be in a left to right language but 
gives an idea of how the layout looks

Cheers,
Marco Martin

>
> Diffs
> -----
>
>   /trunk/KDE/kdelibs/plasma/delegate.cpp
>
> Diff: http://reviewboard.vidsolbach.de/r/274/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Plasma delegate text painting bug
>   http://reviewboard.vidsolbach.de/r/274/s/94/
> Fixed bug in Plasma::Delegate
>   http://reviewboard.vidsolbach.de/r/274/s/95/
>
>
> Thanks,
>
> Jesse
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel