Review Request: Fix for Favorite items in Kickoff

[Aaron J. Seigo]

On Tuesday 18 November 2008, Anne-Marie Mahfouf wrote:
> On Tuesday 18 November 2008 22:34:05 Sebastian Kügler wrote:
> > On Tuesday 18 November 2008 13:51:45 Jesse Zamora wrote:
> > > This patch fixes a bug with Kickoff that Favorite items have "Sort
> > > Ascending" and "Sort Descending" even when they are not in the
> > > favorites view. It also changes the strings to "Sort Alphabetically (A
> > > to Z)" and "Sort Alphabetically (Z to A)". I hope I'm not too late to
> > > get it in trunk..... :-(
> >
> > We're string-frozen since last night. If you want to get this patch in,
> > separate the bugfix from the string changes. The bugfix can be committed
> > now (it looks like a nice improvement). The string changes will have to
> > wait until KDE is unfrozen again (somewhen in January).
>
> No, we're in message freeze only tonight,

yes, so please commit this asap.

(and once again, r-b isn't showing me the patch .. gah... )

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20081118/4a0f65c2/attachment.sig