[REVIEW] integration of kuiserver applet into the systemtray
Jason Stubbs
jasonbstubbs at gmail.com
Tue Nov 18 02:12:07 CET 2008
2008/11/18 Rob Scheepmaker <r.scheepmaker at student.utwente.nl>:
> Because this task is not really
> specific to a protocol, and only relevant to the systray's UI, I've decided to
> put the task providing this icon (SystemTray::Extender::Task) in ui/. Besides,
> it also seemed to me that writing a taskprovider for this situation would be a
> bit overkill since it's just one task that has to be added or removed
> depending on the amount of items in the extender, and it is a task that solely
> concerns the actual systemtray applet. So I've added Applet as a friend to
> TaskArea, to be able to call addTask there directly from applet. If you think
> this decision is wrong, please tell me, and I can still create a taskprovider
> for this.
TaskArea shouldn't really be involved at all. Best would be for Applet
to have a layout that includes the up/down button and a TaskArea.
You'd then be able to control how things are laid out when on the
desktop, too. I gave up on getting layouts to work though; I had to
jump through hoops to get Applet's layout to update its cache of
TaskArea's size hints and it didn't always work.
If you want to commit as-is to get it in before the freeze, I don't
have issue though. That'd at least get any necessary strings in.
--
Jason Stubbs
More information about the Plasma-devel
mailing list