[PATCH] Bugfix for Favorites in Kickoff

[Aaron J. Seigo]

On Monday 17 November 2008, Jesse L. Zamora wrote:
> Hello,
>
> I added support in the Favorites view in Kickoff for sorting in ascending
> order or descending order; however, I had a bad implementation, and that
> resulted in having those context menus being displayed in the other
> UrlItemViews as well, which it shouldn't do (basically in the Applications
> view, right clicking an item that was in the favorites would show the "Sort
> Ascending" and "Sort Descending" context menus. Bad!). Therefore, here is a

the only thing i'd suggest is changing the wording of the actions sorting 
ascending/descending isn't very clear. perhaps "Sort Alphabetically", "Sort 
Reverse Alphabetically"? tells the user exactly what's going to happen there.

the string freeze is tomorrow, in any case. has your svn account come through 
yet?

oh, another tip, for patches, we have http://reviewboard.vidsolbach.de/

we have some scripts to automate uploading patches to it from an svn repo; 
unfortunately mine are a bit old. who has currently-working rb patches?


> P.S. This time I kept whitespace changes separate! :-)

;)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20081117/e8b2c23c/attachment.sig