Review Request: use the usual cache config file for hint-apply-systemcolor presence

Aaron Seigo aseigo at kde.org
Sun Nov 16 21:45:44 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/271/#review264
-----------------------------------------------------------

Ship it!


- Aaron


On 2008-11-16 05:26:19, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/271/
> -----------------------------------------------------------
> 
> (Updated 2008-11-16 05:26:19)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this patch no longer uses plasmarc for the presence or not of those hints but uses the usual theme specific file.
> and expires the cache when system color changes and a tinting is required.
> for some reasons a plasma restart is still required to get colors applied correctly, didn't figured out why (some renderer that doesn't get deleted?)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/theme.h
>   /trunk/KDE/kdelibs/plasma/theme.cpp
>   /trunk/KDE/kdelibs/plasma/svg.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/271/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Plasma-devel mailing list