Review Request: Event id for plasma dbus notification interface

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/270/#review262
-----------------------------------------------------------

Ship it!


good catch ...

- Aaron


On 2008-11-15 03:08:53, Roman Jarosz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/270/
> -----------------------------------------------------------
> 
> (Updated 2008-11-15 03:08:53)
> 
> 
> Review request for Plasma and Roman Jarosz.
> 
> 
> Summary
> -------
> 
> hi, can I add eventId into current plasma dbus notification system?
> 
> I would like to filter Kopete events (and show it differently) based on eventId but plasma doesn't sent it right now. I don't know if it will be possible to change the dbus interface between KDE 4.2 and 4.3 so that's why I'm posting it now so it can go into KDE 4.2.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/notifications/org.kde.VisualNotifications.xml
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/notifications/notificationsengine.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/core/notification.cpp
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/notifications/notificationsengine.h
>   /trunk/KDE/kdebase/runtime/knotify/notifybypopup.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/core/notification.h
> 
> Diff: http://reviewboard.vidsolbach.de/r/270/diff
> 
> 
> Testing
> -------
> 
> I've tested it
> 
> 
> Thanks,
> 
> Roman
> 
>