Review Request: sorting fix in tasks applet
Marco Martin
notmart at gmail.com
Fri Nov 7 11:48:22 CET 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/260/#review253
-----------------------------------------------------------
Ship it!
seems sensible, yeah
- Marco
On 2008-11-06 14:53:37, Christian Mollekopf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/260/
> -----------------------------------------------------------
>
> (Updated 2008-11-06 14:53:37)
>
>
> Review request for Plasma, Aaron Seigo and Marco Martin.
>
>
> Summary
> -------
>
> this patch fixes the sorting in the tasks applet
> use QMultiMap in LayoutWidget so items can be added in any order and still follow the order of the lib
> dont follow the order in the TaskGroupItem
> comment out debug messages
> adapt the itemPositionChanged signal
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h
> /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp
> /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h
> /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.h
> /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.cpp
>
> Diff: http://reviewboard.vidsolbach.de/r/260/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christian
>
>
More information about the Plasma-devel
mailing list