Review Request: QuickSand - KRunner Integration

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/252/#review248
-----------------------------------------------------------

Ship it!


looks ok; the config dialog needs some love, but we can work on that once this is in.

also, could you put all the qs_* files into a "quicksand" subdir? i'll move all the krunner interface classes into a subdir as well.. will keep things a bit tidier i think.

- Aaron


On 2008-11-03 01:37:21, Ryan Bitanga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/252/
> -----------------------------------------------------------
> 
> (Updated 2008-11-03 01:37:21)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The patch integrates QuickSand into KRunner.
> 
> The config dialog now has a general settings tab that contains the interface selection configuration options. It can also preview the selected interface. See attached screenshots.
> 
> Multiple action support is commented out in QuickSand since it's not in trunk yet.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/krunner/CMakeLists.txt
>   /trunk/KDE/kdebase/workspace/krunner/configdialog.h
>   /trunk/KDE/kdebase/workspace/krunner/configdialog.cpp
>   /trunk/KDE/kdebase/workspace/krunner/interface.h
>   /trunk/KDE/kdebase/workspace/krunner/interface.cpp
>   /trunk/KDE/kdebase/workspace/krunner/krunnerapp.h
>   /trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp
>   /trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h
>   /trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp
>   /trunk/KDE/kdebase/workspace/krunner/qs_completionbox.h
>   /trunk/KDE/kdebase/workspace/krunner/qs_completionbox.cpp
>   /trunk/KDE/kdebase/workspace/krunner/qs_dialog.h
>   /trunk/KDE/kdebase/workspace/krunner/qs_dialog.cpp
>   /trunk/KDE/kdebase/workspace/krunner/qs_matchitem.h
>   /trunk/KDE/kdebase/workspace/krunner/qs_matchitem.cpp
>   /trunk/KDE/kdebase/workspace/krunner/qs_matchview.h
>   /trunk/KDE/kdebase/workspace/krunner/qs_matchview.cpp
>   /trunk/KDE/kdebase/workspace/krunner/qs_querymatchitem.h
>   /trunk/KDE/kdebase/workspace/krunner/qs_querymatchitem.cpp
>   /trunk/KDE/kdebase/workspace/krunner/qs_statusbar.h
>   /trunk/KDE/kdebase/workspace/krunner/qs_statusbar.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/252/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Config Dialog
>   http://reviewboard.vidsolbach.de/r/252/s/87/
> Preview
>   http://reviewboard.vidsolbach.de/r/252/s/88/
> 
> 
> Thanks,
> 
> Ryan
> 
>