Review Request: Add support for custom package metadata

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/248/#review242
-----------------------------------------------------------

Ship it!


a little bit of cleanup needed yet, but generally ready to go in.

not sure what your use case was, though this is obviously useful (there was even a comment in there about it =)



/trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.cpp
<http://reviewboard.vidsolbach.de/r/248/#comment195>

    extra ; at end.
    
    also please don't put it all on one line.
    
    PackageStructurePrivate()
        : metadata(0)
    {
    }



/trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.cpp
<http://reviewboard.vidsolbach.de/r/248/#comment196>

    extra ;



/trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.cpp
<http://reviewboard.vidsolbach.de/r/248/#comment198>

    is that really needed?



/trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.cpp
<http://reviewboard.vidsolbach.de/r/248/#comment197>

    for readabiliy, perhaps swap this around:
    
    if (metadataPath.isEmpty()) {
        d->metadata = new PackageMetadata();
    } else {
        d->metadata = new PackageMetadata(metadataPath);
    }
    


- Aaron


On 2008-11-02 03:11:18, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/248/
> -----------------------------------------------------------
> 
> (Updated 2008-11-02 03:11:18)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This adds support for custom package metadata. 
> 
> Update:
> - Default metadata handling in PackageStructure
> - PackageStructure also returns Plasma::PackageMetadata (not a pointer)
> - Always get metadata from the PackageStructure. It creates it on demand.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/package.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/248/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>