Review Request: Add absolute file path support to PackageStructure

Aaron Seigo aseigo at kde.org
Tue Jul 29 03:14:20 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/99/#review102
-----------------------------------------------------------

Ship it!


good work =)

- Aaron


On None, Joe Burns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/99/
> -----------------------------------------------------------
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> PackageStructure::load will now take an absolute filepath and load the structure from there.
> 
> Edit: now it shouldn't break when passed a remote path.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/99/diff
> 
> 
> Testing
> -------
> 
> Loaded a packagestructure file into my soc project plasmagik.
> 
> Edit: test loading a .packagestructure from websvn and also a local .packagestructure
> 
> 
> Thanks,
> 
> Joe
> 
>



More information about the Plasma-devel mailing list