Review Request: Add a Plasma::Slider widget

[Alex Merry]

On Monday 28 July 2008 23:25:21 Aaron J. Seigo wrote:
> On Monday 28 July 2008, Alex Merry wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.vidsolbach.de/r/115/
> > -----------------------------------------------------------
> >
> > Review request for Plasma.
> >
> >
> > Summary
> > -------
> >
> > Wraps the QSlider widget.
> >
> > Design decisions (or what I left out):
> >
> > Didn't bother with any of the "inverted" stuff, stepping or
> > enabling/disabling tracking. Also, no simulating user interaction with
> > the slider (setSliderDown(), etc). No action interface
> > No rangeChanged() signal (since the user can't change it directly)
> > No tick interface, but that can be added later if there's need
> > Made setMinimum() and setMaximum() slots, since I have an immediate use
> > for setMaximum as a slot.
> >
> >
> > Diffs
> > -----
> >
> >   KDE/kdebase/workspace/libs/plasma/CMakeLists.txt
> >   KDE/kdebase/workspace/libs/plasma/includes/Slider
> >   KDE/kdebase/workspace/libs/plasma/widgets/slider.h
> >   KDE/kdebase/workspace/libs/plasma/widgets/slider.cpp
> >
> > Diff: http://reviewboard.vidsolbach.de/r/115/diff
>
> hrm.. review-board seems broken, or at least this patch upload is =((

Hmm... I updated the patch before publishing.  Maybe that was it.

>
> do you want to post the slider.h here?
>
> > Added sliders to the nowplaying applet actually do something when
> > dragged.

Done.  As you might imagine, the .cpp file is somewhat uninteresting.  But 
I've attached the diff as well in case you want to check I haven't done 
anything stupid.

Alex


-- 
KDE: http://www.kde.org
Ubuntu/Kubuntu: http://www.ubuntu.org http://www.kubuntu.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: plasma-widgets-slider.diff
Type: text/x-patch
Size: 9108 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080729/400f4030/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: slider.h
Type: text/x-chdr
Size: 4053 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080729/400f4030/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080729/400f4030/attachment.pgp