KDE/kdebase/workspace/libs/plasma

Aaron J. Seigo aseigo at kde.org
Mon Jul 28 23:43:06 CEST 2008


On Monday 28 July 2008, Alex Merry wrote:
> SVN commit 838833 by alexmerry:
>
> Actually load the operations scheme when we have the information necessary
> to do so.

..

> --- trunk/KDE/kdebase/workspace/libs/plasma/service.cpp #838832:838833
> @@ -150,6 +150,9 @@
>  void Service::setName(const QString &name)
>  {
>      d->name = name;
> +    if (!d->config) {
> +        registerOperationsScheme();
> +    }
>  }

hm... good point, at least for the name based approach. i wonder if this 
shouldn't happen whenever the name changes, however, not only when it's only 
been run once.

see the attached patch; it also fixes the fact that we aren't setting the name 
on plugin creation (though the apidox clearly says otherwise)

thoughts?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: service.diff
Type: text/x-patch
Size: 1947 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080728/8acf3744/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080728/8acf3744/attachment.pgp 


More information about the Plasma-devel mailing list