Review Request: Add a Plasma::Slider widget

Alex Merry huntedhacker at tiscali.co.uk
Mon Jul 28 23:41:53 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/115/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Wraps the QSlider widget.

Design decisions (or what I left out):

Didn't bother with any of the "inverted" stuff, stepping or enabling/disabling tracking.
Also, no simulating user interaction with the slider (setSliderDown(), etc).
No action interface
No rangeChanged() signal (since the user can't change it directly)
No tick interface, but that can be added later if there's need
Made setMinimum() and setMaximum() slots, since I have an immediate use for setMaximum as a slot.


Diffs
-----

  KDE/kdebase/workspace/libs/plasma/CMakeLists.txt
  KDE/kdebase/workspace/libs/plasma/includes/Slider
  KDE/kdebase/workspace/libs/plasma/widgets/slider.h
  KDE/kdebase/workspace/libs/plasma/widgets/slider.cpp

Diff: http://reviewboard.vidsolbach.de/r/115/diff


Testing
-------

Added sliders to the nowplaying applet actually do something when dragged.

The only issue I found was that I get a bunch of "QPainter::begin: Cannot paint on a null pixmap" messages.


Thanks,

Alex



More information about the Plasma-devel mailing list