Review Request: Don't use a custom scrollbar widget in the systemtray job viewer
Marco Martin
notmart at gmail.com
Tue Dec 23 19:01:25 CET 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/313/
-----------------------------------------------------------
(Updated 2008-12-23 10:01:25.292790)
Review request for Plasma.
Summary
-------
This makes the job viewer extenderitem in the systemtray to use just the standard scrollbar widget instead of a custom one and layouts and plasma labels to display the info.
I think it's a pretty important thing to not make custom svg widget proliferate, otherwise theming will become a real mess (a different scrollbar for each possible label disposition would be really bad).
and a thing like that should be done like now or never :)
Diffs
-----
/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.h
/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp
Diff: http://reviewboard.vidsolbach.de/r/313/diff
Testing
-------
tried to start some jobs, it seems to both look and behave in the exact way as before
Thanks,
Marco
More information about the Plasma-devel
mailing list