fuzzy clock?

[Aaron J. Seigo]

hi..

who here feels responsible for the fuzzy clock?

right now it starts an infinite loop when put into a panel, recalculating it's 
size over and over.

i looked at the code, tried a mildly ugly fix that didn't work and then just 
walked away from it because the code is simply unreadable in its current 
state. calculateSize in particular needs some love. breaking it up and having 
proper indentation might be a nice first step.

but the critical problem is that the constraintsEvent is rather broken. it 
doesn't actually check which constraints are being set:

if ( (m_oldContentSize.toSize() != geometry().size() && 
m_oldContentSize.toSize() != QSize (0,0)) || m_configUpdated == true ) { //The 
size changed or config was updated

c'mon, that's why we have a Plasma::SizeConstraint! and in the config case, 
it's reseting all the constraints, so that should be covered with a single 
check to see if SizeConstraint is involved!

it then goes on to update the size ... when SizeConstraint is set! it then 
cycles through possible font sizes, bottoms out at the minimum font size for 
any rational size panel and resizes .. which causes another SizeConstraint to 
be fired.. GOTO 10.

this needs to be fixed before 4.2 goes out. i can't bring myself to work on 
that code due to the shape it is in given that it's not exactly a critical 
component and so much else is out there to do.

if it isn't fixed by whomever has been working on fuzzy clock, i'll be 
removing it from the 4.2 release.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20081221/c35b9b21/attachment.sig